-
Notifications
You must be signed in to change notification settings - Fork 523
WWSTCERT-9786 Inovelli - adding vzw31 red series dimmer switch #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WWSTCERT-9786 Inovelli - adding vzw31 red series dimmer switch #2654
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 480 suites 0s ⏱️ Results for commit e6f6b78. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e6f6b78 |
|
I got the certification request in and passed the test suite. One thing that was strange is that the default multilevel report handler was not sending the level: 0 event. This was causing the driver to timeout when set to 0%. I verified that my device was sending the correct report: 2025-12-20T23:16:21.173926679Z INFO Z-Wave Switch <ZwaveDevice: b79a7858-b383-4072-aaf9-9b5dc1a5e96b [84] (Inovelli Dimmer Red Series)> received Z-Wave command: {args={current_value="OFF_DISABLE", duration=0, target_value=0, value="OFF_DISABLE"}, cmd_class="SWITCH_MULTILEVEL", cmd_id="REPORT", dst_channels={}, encap="NONE", payload="\x00\x00\x00", src_channel=0, version=4} To get it to pass the test I had to handle that report myself. I did not test yet if this is a problem on other devices (maybe something got changed on the default multilevel report handling)? local function onoff_level_report_handler(driver, device, cmd) If I need to create some unit tests I can do it next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please include some unit tests.
I'm not seeing anything in the default handler that would result in the message you posted failing. If you could reproduce and then upload hub logs I could check if you share the hub ID. (At https://my.smartthings.com/advanced under "hubs" click "dump hub logs").
Check all that apply
Type of Change
Checklist
Description of Change
Adding the VZW31-SN dimmer switch. This device is very similar to the VZW32-SN so code addition is minimal.
Summary of Completed Tests
Tested on live device and tested with beta user. Need to run through the test suite still.